-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExpressionTreeForge.extract_element_functions
in parse-function.jl
#181
Conversation
Benchmark resultJudge resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Allow all tests to run, i.e. does not stop at the first error.
Benchmark resultJudge resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paraynaud ! That looks great. I updated OptimizationProblems avion2 and NZF1 to class them as NLS.
….jl (#181) * Add `ExpressionTreeForge.extract_element_functions` in parse-function.jl * Edit parse-function-test.jl Allow all tests to run, i.e. does not stop at the first error.
* Detect NLS pattern * Update src/parse-functions.jl Co-authored-by: Paul Raynaud <[email protected]> * Add `ExpressionTreeForge.extract_element_functions` in parse-function.jl (#181) * Add `ExpressionTreeForge.extract_element_functions` in parse-function.jl * Edit parse-function-test.jl Allow all tests to run, i.e. does not stop at the first error. * fix docstring * apply linter --------- Co-authored-by: Paul Raynaud <[email protected]>
By adding
ExpressionTreeForge.
toextract_element_functions
I got the tests running locally.However, I am not sure about the purpose of the current tests.
If I understand correctly, each test using
isnls
checks if the resultdetect_nls
is equal to what is informed byis_nls
I took a look at the results, here is a summary:
detect_nls
.The ADNLPModel is a sum of squared terms.
Nonetheless, the test fails for this one since
is_nls
returnsfalse
;An Error is generated from
get_expression_tree()
.The
try ... catch
part of the test loop handles it well (by preventing the testis_nls == detect_nls
to happen).Out of 50 problems, 49 are supported, and two of them are least squares problems (producing errors in tests).
Checklist