Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise decompose options #499

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Revise decompose options #499

merged 4 commits into from
Jan 28, 2020

Conversation

mforets
Copy link
Member

@mforets mforets commented Feb 25, 2019

This depends on JuliaReach/LazySets.jl#1179.

To-do's:

@mforets mforets changed the title Revise decompose options WIP - Revise decompose options Feb 25, 2019
@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #499 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #499      +/-   ##
=========================================
- Coverage   55.42%   55.3%   -0.12%     
=========================================
  Files          34      34              
  Lines        1705    1705              
=========================================
- Hits          945     943       -2     
- Misses        760     762       +2
Impacted Files Coverage Δ
src/ReachSets/ContinuousPost/BFFPSV18/BFFPSV18.jl 73.22% <ø> (ø) ⬆️
src/Options/validation.jl 80.95% <0%> (-4.77%) ⬇️
src/ReachSets/DiscretePost/DiscretePost.jl 73.17% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309f6d2...da66ecd. Read the comment docs.

@mforets
Copy link
Member Author

mforets commented Mar 6, 2019

this PR is also relevant for coverage, #47

@schillic
Copy link
Member

Let us fix the two mentioned issues and merge. We should take this over when we work on #679.

@schillic schillic force-pushed the mforets/decompose_options branch from a38e72e to c359d11 Compare September 24, 2019 07:24
@mforets mforets merged commit 916b722 into master Jan 28, 2020
@mforets
Copy link
Member Author

mforets commented Jan 28, 2020

Thanks for the review!

@schillic schillic changed the title WIP - Revise decompose options Revise decompose options Feb 13, 2020
@schillic schillic deleted the mforets/decompose_options branch February 13, 2020 18:51
@schillic schillic mentioned this pull request Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants