Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SDPA tests as broken on v1.10 #158

Merged
merged 1 commit into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/algorithms.jl
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ Base.@kwdef struct TaylorModelsEnclosure <: AbstractDirectRangeAlgorithm
normalize::Bool = true
end

# TODO turn example below into doctest when SDPA works again
"""
SumOfSquaresEnclosure{T} <: AbstractIterativeRangeAlgorithm
Expand All @@ -147,7 +148,7 @@ result of this algorithm is not rigorous.
### Examples
```jldoctest
```example
julia> using SumOfSquares, SDPA, DynamicPolynomials
julia> backend = SDPA.Optimizer;
Expand Down
4 changes: 2 additions & 2 deletions test/multivariate.jl
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ end
# Note: DynamicPolynomials automatically expands p, and evaluation using
# interval arithmetic gives a worse left bound than the factored expression.

if Sys.iswindows()
# SDPA is broken on Windows
if Sys.iswindows() || VERSION >= v"1.10"
# SDPA is broken on Windows or v1.10
@test_broken begin
x = enclose(p, dom, SumOfSquaresEnclosure(; backend=SDPA.Optimizer))
isapprox(inf(x), 0.0; atol=1e-3)
Expand Down
3 changes: 2 additions & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
using Test, RangeEnclosures
using AffineArithmetic, IntervalOptimisation, TaylorModels, SumOfSquares

@static if Sys.iswindows()
@static if Sys.iswindows() || VERSION >= v"1.10"
# SDPA is broken on Windows or v1.10
@test_broken using SDPA
else
using SDPA
Expand Down
4 changes: 2 additions & 2 deletions test/univariate.jl
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ end
rleft, rright = relative_precision(x, xref)
@test rleft ≤ 1e-5 && rright ≤ 1e-5

if Sys.iswindows()
# SDPA is broken on Windows
if Sys.iswindows() || VERSION >= v"1.10"
# SDPA is broken on Windows or v1.10
@test_broken begin
x = enclose(p, dom, SumOfSquaresEnclosure(; backend=SDPA.Optimizer))
xref = interval(4.8333, 10.541)
Expand Down