Allow setting global hooks to modify Easy object #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habemus-papadum
force-pushed
the
hp/easy_hooks
branch
from
dd58fc4 to
9b2c6f0
Compare
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 90.26% 90.60% +0.34%
==========================================
Files 5 5
Lines 575 596 +21
==========================================
+ Hits 519 540 +21
Misses 56 56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
habemus-papadum
force-pushed
the
hp/easy_hooks
branch
from
9b2c6f0 to
a1d80a7
Compare
|
Functionality and unit tests complete. If someone could have an initial glance, that would be much appreciated. Still needed: documentation |
|
added documentation |
habemus-papadum
force-pushed
the
hp/easy_hooks
branch
from
46e79a8 to
57f08f1
Compare
habemus-papadum
force-pushed
the
hp/easy_hooks
branch
from
57f08f1 to
a30270e
Compare
|
I've rebased this PR. It should provide a more robust/composable solution to configuring systemwide download behavior. Any comments regarding the API would be welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a robust way to customize system download behavior (more robust
in comparison to #207)
Todo
- Timeout options
- CA paths
- rewrite urls