Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of -0.0 to 0.0 #500

Merged
merged 7 commits into from
Dec 14, 2021
Merged

Fix display of -0.0 to 0.0 #500

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b23476d
Fix display of -0.0 to 0.0
lbenet Dec 13, 2021
495a7a2
Add _normalisezero (instead of _signofzero) and fix display of inf
lbenet Dec 14, 2021
89feefe
Reposition use of _normalisezero
lbenet Dec 14, 2021
2a95678
fix atan2 for decorated intervals
lucaferranti Dec 14, 2021
816cd99
small update
lucaferranti Dec 14, 2021
99b8fd2
Clean-up _normalisezero
lbenet Dec 14, 2021
8201058
Bump patch version
lbenet Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/intervals/arithmetic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ end


# Infimum and supremum of an interval
inf(a::Interval) = a.lo
inf(a::Interval) = ifelse(iszero(a.lo) && !signbit(a.lo), copysign(a.lo, -1), a.lo)
sup(a::Interval) = a.hi
lbenet marked this conversation as resolved.
Show resolved Hide resolved


Expand Down
7 changes: 5 additions & 2 deletions src/intervals/intervals.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ struct Interval{T<:Real} <: AbstractInterval{T}
function Interval{T}(a::Real, b::Real) where T<:Real

if validity_check

a = _normalisezero(a)
lbenet marked this conversation as resolved.
Show resolved Hide resolved
b = _normalisezero(b)
if is_valid_interval(a, b)
new(a, b)
return new(a, b)

else
@warn "Invalid input, empty interval is returned"
Expand All @@ -36,6 +37,8 @@ struct Interval{T<:Real} <: AbstractInterval{T}
end
end

@inline _normalisezero(a::Real) = ifelse(iszero(a) && signbit(a), copysign(a, 1), a)
@inline _normalisezero(a::Integer) = float(a)
lbenet marked this conversation as resolved.
Show resolved Hide resolved


## Outer constructors
Expand Down