Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to artifact device libraries if ROCm 5.5+ is detected #540

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented Nov 19, 2023

  • Switch to artifact device libraries if ROCm 5.5+ is detected.
    Should work on Julia 1.9 & 1.10 and ROCm 5.3 - 5.7.
  • Remove use_devlibs_jll preference as there is no need for it now.
  • Rename enable_artifacts! to use_artifacts! to be in line with use_artifacts.

@pxl-th pxl-th mentioned this pull request Nov 19, 2023
@pxl-th pxl-th merged commit 45163c5 into master Nov 19, 2023
7 checks passed
@pxl-th pxl-th deleted the pxl-th/auto-devlibs branch November 19, 2023 12:21
@luraess
Copy link
Contributor

luraess commented Nov 19, 2023

Tried AMDGPU#master without "mixed-mode" install with local ROCm 5.6.1 install and Julia 1.10-rc1 on RX 7800XT GPU and it fails to get the device libs from artifacts:

julia> using AMDGPU
┌ Warning: Device libraries are unavailable, device intrinsics will be disabled.
└ @ AMDGPU ~/.julia/packages/AMDGPU/0Zp2i/src/AMDGPU.jl:197

julia> AMDGPU.versioninfo()
ROCm provided by: system
[+] HSA Runtime v1.1.0
    @ /opt/rocm-5.6.1/lib/libhsa-runtime64.so
[+] ld.lld
    @ /opt/rocm/llvm/bin/ld.lld
[-] ROCm-Device-Libs
[+] HIP Runtime v5.6.31062
    @ /opt/rocm-5.6.1/lib/libamdhip64.so
[+] rocBLAS v3.0.0
    @ /opt/rocm-5.6.1/lib/librocblas.so
[+] rocSOLVER v3.22.0
    @ /opt/rocm-5.6.1/lib/librocsolver.so
[+] rocALUTION
    @ /opt/rocm-5.6.1/lib/librocalution.so
[+] rocSPARSE
    @ /opt/rocm-5.6.1/lib/librocsparse.so.0
[+] rocRAND v2.10.5
    @ /opt/rocm-5.6.1/lib/librocrand.so
[+] rocFFT v1.0.21
    @ /opt/rocm-5.6.1/lib/librocfft.so
[+] MIOpen v2.20.0
    @ /opt/rocm-5.6.1/lib/libMIOpen.so

HIP Devices [1]
    1. HIPDevice(name="AMD Radeon Graphics", id=1, gcn_arch=gfx1101)

julia> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants