Skip to content

Commit

Permalink
Use 1.10 in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
pxl-th committed Nov 14, 2023
1 parent 7626894 commit a7596be
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 4 deletions.
24 changes: 22 additions & 2 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,30 @@ steps:
if: build.message !~ /\[skip docs\]/
timeout_in_minutes: 10

- label: "Julia 1.9 - No Artifacts"
# - label: "Julia 1.9 - No Artifacts"
# plugins:
# - JuliaCI/julia#v1:
# version: 1.9
# - JuliaCI/julia-test#v1:
# - JuliaCI/julia-coverage#v1:
# codecov: true
# agents:
# queue: "juliagpu"
# rocm: "*"
# rocmgpu: "gfx1031"
# if: build.message !~ /\[skip tests\]/
# command: "julia --project -e 'using Pkg; Pkg.update()'"
# timeout_in_minutes: 180
# env:
# JULIA_NUM_THREADS: 4
# JULIA_AMDGPU_CORE_MUST_LOAD: "1"
# JULIA_AMDGPU_HIP_MUST_LOAD: "1"
# JULIA_AMDGPU_DISABLE_ARTIFACTS: "1"

- label: "Julia 1.10 - No Artifacts"
plugins:
- JuliaCI/julia#v1:
version: 1.9
version: 1.10
- JuliaCI/julia-test#v1:
- JuliaCI/julia-coverage#v1:
codecov: true
Expand Down
4 changes: 2 additions & 2 deletions src/device/gcn/hostcall.jl
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ function HostCallHolder(

try
if ret_buf[].ptr != C_NULL && ret_len < sizeof(ret)
Mem.free(ret_buf[])
# Mem.free(ret_buf[])
ret_len = sizeof(ret)
ret_buf[] = Mem.HostBuffer(ret_len, AMDGPU.HIP.hipHostAllocMapped)
elseif ret_buf[].ptr == C_NULL
Expand Down Expand Up @@ -179,7 +179,7 @@ function HostCallHolder(
prev == HOST_ERR_SENTINEL ||
prev == DEVICE_ERR_SENTINEL
if not_used
Mem.free(ret_buf[]) # `free` checks for C_NULL.
# Mem.free(ret_buf[]) # `free` checks for C_NULL.
buf_ptr = reinterpret(Ptr{Cvoid}, hc.buf_ptr)
HIP.hipHostFree(buf_ptr) |> HIP.check
break
Expand Down

0 comments on commit a7596be

Please sign in to comment.