Fix show_src_expr on 32 bit Julia

[Zentrik]

Fixes #524.

_lastidx is a UInt32, so the result of catchup ends up a UInt32. This then gets assigned to position (line 80) which is expected to be an Int. I didn't convert _lastidx to an Int because I thought converting the return value might minimise the chances of an InexactError.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c96853) 0.00% compared to head (13b5375) 0.00%.

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #525   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9       9           
  Lines        1551    1551           
======================================
  Misses       1551    1551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Zentrik]

Perhaps we should add some x86 CI.

[ThatcherC]

Were you able to get this to run on 1.9~x86? I still get the same error when running those locally:

(test-x86) pkg> rm Cthulhu

(test-x86) pkg> precompile

(test-x86) pkg> add https://github.com/Zentrik/Cthulhu.jl#fix-32-bit
    Updating git-repo `https://github.com/Zentrik/Cthulhu.jl`
   Resolving package versions...
    Updating `~/Programs/test-x86/Project.toml`
  [f68482b8] + Cthulhu v2.10.0 `https://github.com/Zentrik/Cthulhu.jl#fix-32-bit`
    Updating `~/Programs/test-x86/Manifest.toml`
  [1520ce14] + AbstractTrees v0.4.4

[...]

  [4ec0a83e] + Unicode
Precompiling project...
  ✗ Cthulhu
  0 dependencies successfully precompiled in 13 seconds. 8 already precompiled.
  1 dependency errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the package

(test-x86) pkg> precompile
Precompiling project...
  ✗ Cthulhu
  0 dependencies successfully precompiled in 13 seconds. 8 already precompiled.
[...]

[Zentrik]

Odd I thought it was fixed locally, but I do see the same error though subtly different.

[Zentrik]

You need to fetch the version of TypedSyntax from this fork as well by doing add https://github.com/Zentrik/Cthulhu.jl#fix-32-bit:TypedSyntax. I'll merge this in once I figure out if the IntegrationTest failure is legitimate or not.

[ThatcherC]

Ah nice, that did the trick, thanks! I'm able to use @descend now in my 32-bit Julia. Very cool!

[Zentrik]

I see the same CI errors on master and on a new pr, so going to merge this in.