Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default version to 1.10.4 #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch default version to 1.10.4 #476

wants to merge 1 commit into from

Conversation

oxinabox
Copy link
Collaborator

As of a few hours ago 1.10.4 is the LTS

not sure how much this breaks in the tests.
I bet it does, but i hope it doesn't
Will follow up to fix those if needed

Not sure if should also update our CI setup

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.26%. Comparing base (f1c4302) to head (5ff9fe2).

Files Patch % Lines
src/template.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f1c4302) and HEAD (5ff9fe2). Click for more details.

HEAD has 148 uploads less than BASE
Flag BASE (f1c4302) HEAD (5ff9fe2)
152 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #476       +/-   ##
===========================================
- Coverage   94.33%   69.26%   -25.08%     
===========================================
  Files          24       24               
  Lines         742      615      -127     
===========================================
- Hits          700      426      -274     
- Misses         42      189      +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Collaborator

gdalle commented Jul 10, 2024

Indeed 1.10 will be the LTS but it's not the case yet and it won't be as long as 1.11 hasn't been released, right?

@oxinabox
Copy link
Collaborator Author

idk, last time LTS was changed it was indeed not til the release after it stopped being stable.
But the announcement at state of julia sounded like it was being made the LTS now.

1.11 is just around the corner anyway.

@cvigilv
Copy link

cvigilv commented Jan 1, 2025

Julia's LTS now its 1.10, any intention on revisiting this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants