-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move functionality from Javis to JavisViewer #2
base: main
Are you sure you want to change the base?
Conversation
Hi @TheCedarPrince I started working on this, it would be nice if you could merge this PR so we have CI working or give me merge access and I can do it myself. It is not finished yet but just so we can set up some initial stuff it should be good to go, test locally and it works. |
I did not know this but since it is not running here CI runs on my fork! So no rush at all!! |
Hey @gpucce , you should now have access to all the things! |
I can give more of a review later - right now, quite tired! |
I was going to ask you if you wanted to move the streaming as well, that I will move back then!! |
I think streaming is pretty much basic so better to keep it in base Javis. In the future I am thinking of having such features out of base(in a |
Hi @TheCedarPrince this should be the JavisViewer package! If you can review it and let me know if smth is missing i will add it! |
This PR is meant to move all the interactive and liveviewing parts of
Javis
toJavisViewer
Closes:
#1