Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: put emojisplosions back on homepage: root-level <script> #903

Merged
merged 1 commit into from
Jan 13, 2025
Merged

docs: put emojisplosions back on homepage: root-level <script> #903

merged 1 commit into from
Jan 13, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Moves the <script> into index.astro, because that seems to work. I would have preferred #902 but that seems to be some kind of Astro compiler issue.

Co-authored-by: @ElianCodes

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: d0dbd22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emoji-blast ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 1:17pm

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix: put emojisplosions back on homepage: root-level <script> docs: put emojisplosions back on homepage: root-level <script> Jan 13, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 1f676b9 into main Jan 13, 2025
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the site-emojis-back-script branch January 13, 2025 13:18
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (76044a9) to head (d0dbd22).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #903   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @ElianCodes for doc.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Jan 13, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @ElianCodes! 🎉

JoshuaKGoldberg added a commit that referenced this pull request Jan 13, 2025
@JoshuaKGoldberg
docs: add eliancodes as a contributor for doc (#904)
55b75eb 
Adds @ElianCodes as a contributor for doc.

This was requested by JoshuaKGoldberg [in this
comment](#903 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Documentation: Website is no longer exploding emojis
1 participant
@JoshuaKGoldberg