add test

add a max number of records to load fixes phpmyadmin#42
JoolsMcFly · Dec 11, 2024 · 6415d24 · 6415d24
1 parent 7d8bb8b
commit 6415d24
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/ShapeFile.php b/src/ShapeFile.php
@@ -83,6 +83,8 @@ class ShapeFile
 
     private bool $allowNoDbf = false;
 
+    private bool|int $maxRecords = false;
+
     /**
      * Checks whether dbase manipulations are supported.
      */
@@ -108,6 +110,11 @@ public function __construct(
     ) {
     }
 
+    public function setMaxRecords(int|bool $max): void
+    {
+        $this->maxRecords = $max;
+    }
+
     public function setAllowNoDbf(bool $allowNoDbf): void
     {
         $this->allowNoDbf = $allowNoDbf;
@@ -492,6 +499,10 @@ private function loadRecords(): bool
             }
 
             $this->records[] = $record;
+
+            if ($this->maxRecords !== false && count($this->records) > $this->maxRecords) {
+                return true;
+            }
         }
 
         return true;

diff --git a/tests/ShapeFileTest.php b/tests/ShapeFileTest.php
@@ -429,4 +429,18 @@ public function testAllowsNoDbf(): void
         $shp->setAllowNoDbf(true);
         self::assertTrue($shp->loadFromFile('data/no-dbf.*'));
     }
+
+    public function testMaxNumberRecords(): void
+    {
+        if (! ShapeFile::supportsDbase()) {
+            self::markTestSkipped('dbase extension missing');
+        }
+
+        $this->createTestData();
+
+        $shp = new ShapeFile(ShapeType::Point);
+        $shp->setMaxRecords(5);
+        $shp->loadFromFile('data/mexico.*');
+        self::assertCount(5, $shp->records);
+    }
 }