chore(cordova/apple): remove Outline-Info.plist files #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
changed the title
jyyi1
reviewed
Dec 16, 2022
| version="1.9.0" | ||
| id="org.outline.android.client" android-versionCode="43" | ||
| ios-CFBundleIdentifier="org.outline.ios.client" ios-CFBundleVersion="35" | ||
| > |
There was a problem hiding this comment.
nit It seems Google does not recommend to put > in a dedicated line. A sample of multi-line HTML, maybe the following style?
<widget xmlns=...
version="1.9.0"
id=...
ios-CFBundleIdentifier=...>
daniellacosse
requested changes
Dec 16, 2022
There was a problem hiding this comment.
We need to update the src/build/get_version and src/build/get_build_number
daniellacosse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, do the edits in the config.xml file instead.
See 6d88d4d for a reorganized Outline-Info.plist that makes it easier to see what needed to be added via config.xml.
/cc @eacrh @jyyi1