Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing images from wikidata and wikipedia #2083

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Add missing images from wikidata and wikipedia #2083

merged 3 commits into from
Dec 10, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Dec 10, 2024

It does so by adding "Attribution" field support and permissive licenses.
The following are the images from the linked issue:
image
image
image

https://israelhiking.osm.org.il/poi/OSM/node_278474873?language=he

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (1715972) to head (e065610).

Files with missing lines Patch % Lines
...g.Web/src/application/services/wikidata.service.ts 0.00% 7 Missing ⚠️
.../application/services/image-attribution.service.ts 90.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
- Coverage   90.59%   90.54%   -0.06%     
==========================================
  Files         101      101              
  Lines        8580     8596      +16     
  Branches     1075     1081       +6     
==========================================
+ Hits         7773     7783      +10     
- Misses        579      585       +6     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 92eb907 into main Dec 10, 2024
6 of 7 checks passed
@HarelM HarelM deleted the 2081-fix branch December 10, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing images from wikidata and wikipedia
3 participants