Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Select selector from ngxs due to deperaction #2010

Merged
merged 30 commits into from
Jun 16, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Jun 13, 2024

This PR replaces all the @Select in the code to remove the soon to be deprecated decorators.
Related to:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (050e63b) to head (c5d91cb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   91.38%   91.36%   -0.02%     
==========================================
  Files          93       93              
  Lines        8122     8106      -16     
  Branches      985      985              
==========================================
- Hits         7422     7406      -16     
  Misses        475      475              
  Partials      225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Member Author

HarelM commented Jun 13, 2024

I've tested all the components that were affected to the best I could.
I think this is OK to be merged.

@HarelM HarelM merged commit 0374c76 into main Jun 16, 2024
12 of 13 checks passed
@HarelM HarelM deleted the remove-ngx-select-decorator branch June 16, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants