Skip to content

Commit

Permalink
Upgrade to node 20
Browse files Browse the repository at this point in the history
  • Loading branch information
HarelM committed Apr 4, 2024
1 parent 38d8607 commit 2c6abbf
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18.16'
node-version: '20.12'

- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
dotnet-version: '7.0'

- name: Run backend tests
run: dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:Exclude="[IsraelHiking.Common]*" --logger "junit;LogFilePath=test-result.xml"
run: dotnet test Tests/IsraelHiking.API.Tests --logger "junit;LogFilePath=test-result.xml" /p:CollectCoverage=true /p:CoverletOutputFormat=lcov /p:Exclude="[IsraelHiking.Common]*"
- name: Run frontend tests
run: |
cd IsraelHiking.Web
Expand All @@ -45,6 +45,6 @@ jobs:
uses: test-summary/action@v2
with:
paths: |
./**/IsraelHiking.API.Tests/test-result.xml
./**/test-result.xml
./**/TESTS-*.xml
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.16 as build-node
FROM node:20.12 as build-node

WORKDIR /angular
COPY ./IsraelHiking.Web/ ./
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ The architecture is based on layers:
In order to be able to build this site you'll need some tools:
* Install [Docker](https://www.docker.com/products/docker-desktop)
* Install [.Net core SDK 7.0 ](https://www.microsoft.com/net/download/core)
* Install [node.js](https://nodejs.org/en/) (18.16+).
* Install [node.js](https://nodejs.org/en/) (20+).
* Run from command line `dotnet restore` and after that `dotnet build`
* Go to `IsraelHiking.Web` and run from command line:
* `npm install` to install all npm packages for the client side code
Expand Down
4 changes: 2 additions & 2 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ for:
only:
- PRODUCT: android
install:
- ps: Install-Product node 18.16
- ps: Install-Product node 20.12
build_script:
- pwsh: >-
$BuildAndPublishAndroid = "$env:APPVEYOR_BUILD_FOLDER/Scripts/BuildAndPublishAndroid.ps1"
Expand All @@ -60,7 +60,7 @@ for:
- PRODUCT: ios
fast_finish: true
install:
- sh: nvm install 18.16
- sh: nvm install 20.12
build_script:
- pwsh: >-
$BuildAndPublishIOS = "$env:APPVEYOR_BUILD_FOLDER/Scripts/BuildAndPublishIOS.ps1"
Expand Down

0 comments on commit 2c6abbf

Please sign in to comment.