-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP mux improvements for 10.2.1 #5077
Draft
karknu
wants to merge
12
commits into
release/ouroboros-network-0.19
Choose a base branch
from
karknu/10_2_1_read_buffer
base: release/ouroboros-network-0.19
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower level benchmark for reading and writing over Sockets. Uses local TCP sockets over ephemeral ports.
Reading a Mux segment used to require at least two syscalls. One two read the header and one to read the rest of the data. This change reads up to RecvBuffer bytes into a buffer in one go and then serves data from it.
Enforce at least 1 byte payload data per SDU.
Permit sending of multiple SDUs through a single call to sendMany for Socket bearers Bearers without vector IO support emulate it through multiple calls to write.
6c7acb8
to
f5a2cca
Compare
This implements an optional read buffer for the Socket bearer.
f5a2cca
to
6bba9f0
Compare
karknu
commented
Feb 18, 2025
karknu
commented
Feb 18, 2025
karknu
commented
Feb 18, 2025
karknu
commented
Feb 18, 2025
Define msHeaderLength and use it instead of 8 as hardcoded headerlength.
2e1b74b
to
dd44444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reasonably detailed description of the pull request
Checklist
Quality
Maintenance
ouroboros-network
project.