Remove NodeToNodeV_13 #5068
Open
Remove NodeToNodeV_13 #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mwojtowicz/remove-nodetonode-v13
branch
2 times, most recently
from
b29aa27 to
576537a
Compare
|
Could you add to the description the date that the HF happened please. |
crocodile-dentist
force-pushed
the
mwojtowicz/remove-nodetonode-v13
branch
from
576537a to
a7a554d
Compare
(See CHANGELOG for more details)
- Extract Cardano-specific components into separate modules to resolve cyclic dependency issues:
- `ConsensusModePeerTargets` and `PeerSelectionTargets` were refactored to avoid circular dependencies.
- Introduce extension points in Diffusion data structures:
- Split P2P functionality into `P2PCardano` (for Cardano Node specifics) and a more general `P2P` module.
- Added `Minimal/Node.hs` as a placeholder for a minimal Node diffusion instantiation example.
- Refactor Peer Selection:
- Removed redundant `PeerSelectionActionsArgs`.
- Reorganized `DNSActions` and `LedgerPeersArgs`.
- Improved API for `PeerSelectionActions`.
- Rename `Cardano.Node` to `Cardano.Network`.
- Generalize and refactor the following components:
- `ConsensusModePeerTargets`.
- `PeerSelection{Views, Counters}` to allow extensibility for third-party users.
- `PublicRootPeers`.
- Enhance the Outbound Governor:
- Generalize `MinimalP2P` for diffusion initialization.
- Update `ArgumentsExtra` with new parameters for a more flexible diffusion setup.
- Refactor `PeerSelection.Governor.Monitor` to separate Cardano-specific monitoring actions and support third-party custom actions.
- Ensure the `Diffusion` module is fully polymorphic:
- Removed `CardanoP2P` dependencies.
- Updated the test suite to align with the new structure.
- Miscellaneous updates:
- Update CHaP and fix build issues.
- Remove `daBlockFetchMode`.
- Address review feedback.
- Fix churn timeout tests and increase `shortDelay` to stabilize tests.
- Recover `sigusr1` signal handler.
- Make addresses polymorphic.
- Refactor `extraDebugState` and introduce `P2PDecisionType`.
- Refactor `requestPublicRootPeers` type.
It's not needed.
They are passed as a closure, no need to leak them outside of `Cardano` (or any other 3rd party integration).
Instead of specifying `extraAPI ~ ()` for non-p2p, we can make it polymorphic. This way both p2p & non-p2 `Application` type is using the same type variables, and the wrapper type can be removed. This is more in-line with removal of non-p2p code base.
Also adhere to the convention: first `extraFlags`, then `extraPeers`
We can pass `PeerSelectionInterfaces` to `updateWithState` function to get access to `readUseLedgerPeers`.
Also edit export lists so that we need fewer imports.
V13 is unable to cross Plomin HF manadatory on mainnet as of 2025.01.29
crocodile-dentist
force-pushed
the
mwojtowicz/remove-nodetonode-v13
branch
from
a7a554d to
99a7245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drops V13 which is incapable of crossing Plomin HF as of 2025.01.29
Resolves #5057
Checklist
Quality
Maintenance
ouroboros-networkproject.