Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deepseek-r1 chat template #3072

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add deepseek-r1 chat template #3072

wants to merge 3 commits into from
+64 −0

Conversation

AllentDan
Copy link
Collaborator

lvhan028
lvhan028 reviewed Jan 22, 2025
View reviewed changes
tests/test_lmdeploy/test_model.py


@pytest.mark.parametrize('model_path_or_name', [
'deepseek-ai/DeepSeek-R1-Distill-Llama-70B',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May add all models in the group https://huggingface.co/collections/deepseek-ai/deepseek-r1-678e1e131c0169c0bc89728d to the test cases.

@AllentDan AllentDan mentioned this pull request Jan 23, 2025
Open
@vladrad
Copy link

vladrad commented Jan 23, 2025 •
edited
Loading

Im just 👀 to learn how you did it. Maybe if its easy like this I can add the next one?

@AllentDan
Copy link
Collaborator Author

Yes, @vladrad it is pretty easy to add a new chat template yourself. Check our doc out.

vladrad
vladrad approved these changes Jan 25, 2025
View reviewed changes
lmdeploy/model.py

def messages2prompt(self, messages, sequence_start=True, **kwargs):
if sequence_start and not isinstance(messages, str):
return '<｜begin▁of▁sentence｜>' + super().messages2prompt(messages, sequence_start, **kwargs)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to include the tags?

@vladrad
Copy link

vladrad commented Jan 25, 2025

Thank you I’ll try to do one next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@vladrad vladrad vladrad approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllentDan @vladrad @lvhan028