Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [RN][Android] call setTrackUserSteps in android to enable/disable user steps tracking #1341

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: [RN][Android] call setTrackUserSteps in android to enable/disable user steps tracking #1341

wants to merge 3 commits into from

Conversation

AyaMahmoud148
Copy link

@AyaMahmoud148 AyaMahmoud148 commented Jan 13, 2025 •
edited
Loading

Description of the change

setTrackingUserSteps api not been called in android

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

https://instabug.atlassian.net/browse/MOB-17077

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@AyaMahmoud148 AyaMahmoud148 changed the title fix: [RN][Android] setTrackUserSteps API not handled on the Android R… feat: [RN][Android] call setTrackUserSteps in android to enable/disable user steps tracking Jan 13, 2025
@InstabugCI
Copy link
Collaborator

Warnings
⚠️

You have not included a CHANGELOG entry!
You can find it at CHANGELOG.md.

Coverage Report

Label Coverage Status
JavaScript 95.2% ✅
Android 50.3% ✅
iOS 51.6% ✅

Generated by 🚫 dangerJS against fd03364

ahmedAlaaInstabug
ahmedAlaaInstabug approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@kholood-ea kholood-ea kholood-ea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AyaMahmoud148 @InstabugCI @kholood-ea @ahmedAlaaInstabug @AndrewAminInstabug