Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple ITK-Wasm DICOM SEG example #764

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add simple ITK-Wasm DICOM SEG example #764

wants to merge 2 commits into from
+303 −31

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 21, 2024

supersedes #759

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@thewtex
Copy link
Member

thewtex commented Jan 8, 2025

@PaulHax this is great!

Is this ready-to-go?

Rebase on main for CI?

@thewtex
Copy link
Member

thewtex commented Jan 8, 2025 •
edited
Loading

pydicom_seg appears to be broken in newer Python / PyDICOM -- I think we should use itkwasm-dicom instead.

@thewtex
Copy link
Member

thewtex commented Jan 8, 2025

Test failure:

FAILED examples/integrations/itkwasm/DICOM_SEG.ipynb:: - A cell timed out while it was being executed, after 3000 seconds.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Jan 8, 2025

pydicom_seg appears to be broken in newer Python / PyDICOM -- I think we should use itkwasm-dicom instead.

Yes, #757 does that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulHax @thewtex