Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: unused variable 'numberOfPoints' #4

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

hjmjohnson
Copy link
Member

A variable that is not used is removed.

A variable that is not used is removed.
@hjmjohnson hjmjohnson requested a review from thewtex November 25, 2024 14:36
@@ -236,7 +236,6 @@ ::ReadCells(void * buffer)
auto * data = static_cast<unsigned int *>(buffer);

// Skip root
const SizeValueType numberOfPoints = this->GetNumberOfPoints();
SizeValueType cellBufferIndex = 0;
for (SizeValueType pointIndex = 1; pointIndex < this->GetNumberOfPoints(); ++pointIndex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That variable was probably meant to be used here.

@jhlegarreta
Copy link
Member

See if PR #5 helps with the CIs.

@dzenanz
Copy link
Member

dzenanz commented Nov 26, 2024

Please rebase

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjmjohnson thanks!

@thewtex thewtex merged commit 6cc788b into main Nov 29, 2024
63 checks passed
@thewtex thewtex deleted the remove-unused-variable branch November 29, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants