Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Transition project configuration to pyproject.toml #3

Merged

Conversation

jhlegarreta
Copy link
Member

Transition project configuration to pyproject.toml.

Used the setup-py-to-pyproject-toml.py script in the ITKModuleTemplate repository:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate

as a starting base, then made manual changes as necessary.

Require itk == 5.4.* and bump the package to a new major version.

pyproject.toml Outdated Show resolved Hide resolved
@jhlegarreta jhlegarreta force-pushed the TransitionToPyprojectToml branch from 8fa22cd to ce9565d Compare September 7, 2024 16:15
@hjmjohnson
Copy link
Member

@jhlegarreta Is this effort abandoned?

@jhlegarreta jhlegarreta force-pushed the TransitionToPyprojectToml branch from ce9565d to f7341fa Compare November 25, 2024 23:06
@jhlegarreta
Copy link
Member Author

@jhlegarreta Is this effort abandoned?

It is not; adopting pyproject.toml for project configuration should work. Errors are related to the ITKRemoteModuleBuildTestPackageAction version:
https://github.com/InsightSoftwareConsortium/ITKIOMeshSWC/actions/runs/12020402905/job/33508940808#step:1:36
https://github.com/InsightSoftwareConsortium/ITKIOMeshSWC/actions/runs/12020402905/job/33508941162#step:8:171

@jhlegarreta
Copy link
Member Author

So to be clear, there is no further work required here: it should be safe to be merged once PR #5 gets merged and this one is rebased on main.

Transition project configuration to `pyproject.toml`.

Used the `setup-py-to-pyproject-toml.py` script in the
`ITKModuleTemplate` repository:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate

as a starting base, then made manual changes as necessary.

Require `itk == 5.4.*` and bump the package to a new minor version.
@jhlegarreta jhlegarreta force-pushed the TransitionToPyprojectToml branch from f7341fa to 4eaaf91 Compare November 26, 2024 20:14
@jhlegarreta
Copy link
Member Author

@hjmjohnson Checks are passing.

@dzenanz dzenanz merged commit b106a87 into InsightSoftwareConsortium:main Nov 27, 2024
32 checks passed
@jhlegarreta jhlegarreta deleted the TransitionToPyprojectToml branch November 27, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants