Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Upgrade CI for ITK 5.4.0 #26

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jun 19, 2024

Upgrade CI testing to use the latest ITK 5.4.0 version and CI configuration.

Committed via https://github.com/asottile/all-repos

Upgrade CI testing to use the latest ITK 5.4.0 version and CI configuration.

Committed via https://github.com/asottile/all-repos
@dzenanz
Copy link
Member

dzenanz commented Jun 19, 2024

In file included from /Users/runner/work/ITKBioCell/ITKBioCell/src/itkBioCellularAggregateBase.cxx:19:
/Users/runner/work/ITKBioCell/ITKBioCell/include/itkBioCellularAggregateBase.h:53:16: error: unknown type name 'BioCellularAggregateBase'; did you mean 'CellularAggregateBase'?
  itkTypeMacro(BioCellularAggregateBase, Object);
               ^~~~~~~~~~~~~~~~~~~~~~~~
               CellularAggregateBase
/Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/Modules/Core/Common/include/itkMacro.h:480:78: note: expanded from macro 'itkTypeMacro'
#  define itkTypeMacro(thisClass, superclass) itkOverrideGetNameOfClassMacro(thisClass)
                                                                             ^
/Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/Modules/Core/Common/include/itkMacro.h:464:93: note: expanded from macro 'itkOverrideGetNameOfClassMacro'
  const char * GetNameOfClass() const override itkInternalGetNameOfClassImplementationMacro(thisClass)
                                                                                            ^
/Users/svc-dashboard/D/P/ITKPythonPackage/ITK-source/ITK/Modules/Core/Common/include/itkMacro.h:449:34: note: expanded from macro 'itkInternalGetNameOfClassImplementationMacro'
    static_assert(std::is_same_v<thisClass, std::remove_const_t<std::remove_reference_t<decltype(*this)>>>, \
                                 ^
/Users/runner/work/ITKBioCell/ITKBioCell/include/itkBioCellularAggregateBase.h:41:22: note: 'CellularAggregateBase' declared here
class BioCell_EXPORT CellularAggregateBase : public Object
                     ^
1 error generated.

We might want to remove BioCell from the list of remote modules.

@dzenanz
Copy link
Member

dzenanz commented Jun 19, 2024

Related to InsightSoftwareConsortium/ITK#4263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants