STYLE: Move empty const member functions from .hxx to .h
#5221
+5
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the member function definitions of `const`member functions that have an empty
member function definition from their "itk*.hxx" file to the corresponding
"itk*.h" file, and into their class definition.
Found by regular expression `^..[^:,].+\) const\r\n{}` in "itk*.hxx" files.
- Follow-up to pull request InsightSoftwareConsortium#5198
commit b94770d
"STYLE: Move empty member functions with empty param list from .hxx to .h"
github-actions
bot
added
area:Filtering
dzenanz
approved these changes
Feb 6, 2025
N-Dekker
commented
Feb 6, 2025
Comment on lines
+93
to
+95
| GetDerivative(const TransformParametersType & itkNotUsed(parameters), | ||
| DerivativeType & itkNotUsed(derivative)) const override | ||
| {} |
There was a problem hiding this comment.
It appears that EuclideanDistancePointMetric::GetDerivative has always been empty, looking at commit 06e94a2 (10 Oct 2004):
ITK/Code/Algorithms/itkEuclideanDistancePointMetric.txx
Lines 145 to 150 in 06e94a2
Just curious, was it still meant to be implemented? Or was it intentionally left empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the member function definitions of
constmember functions that have an empty member function definition from their "itk*.hxx" file to the corresponding "itk*.h" file, and into their class definition.Found by regular expression
^..[^:,].+\) const\r\n{}in "itk*.hxx" files."STYLE: Move empty member functions with empty param list from .hxx to .h"