Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: macOS-11 Azure CI environment EOL #4735

Conversation

hjmjohnson
Copy link
Member

The macOS-11 environment is deprecated and scheduled to be removed on June 28th, 2024.

Update to macos-12 (also Intel) because macos-14 images are ARM and the ARM testing is done with GitHub Actions.

@hjmjohnson hjmjohnson requested review from thewtex and blowekamp June 20, 2024 13:03
@hjmjohnson hjmjohnson added the type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct label Jun 20, 2024
@hjmjohnson hjmjohnson self-assigned this Jun 20, 2024
@hjmjohnson hjmjohnson added this to the ITK 5.4.1 milestone Jun 20, 2024
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes both to macos-13?

The macOS-11 environment is deprecated and scheduled
to be removed on June 28th, 2024.

Update to macos-13 (also Intel) because macos-14 images
are ARM and the ARM testing is done with GitHub Actions.
@hjmjohnson hjmjohnson force-pushed the release-5.4-CI-update branch from 1756991 to e5de32a Compare June 20, 2024 13:09
@hjmjohnson
Copy link
Member Author

This changes both to macos-13?

Yes. Comment fixed. macos-12 had a false positive compiler warning about linking during python wrapping.
ld: warning: -undefined dynamic_lookup may not work with chained fixups

macos-13 is also an intel based deployment where the compilers are fixed.

After suggestion by @thewtex we moved from 11 to 13 to avoid a lot of CI headaches.

@hjmjohnson hjmjohnson requested a review from dzenanz June 20, 2024 13:11
Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots labels Jun 20, 2024
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@thewtex thewtex merged commit 61af745 into InsightSoftwareConsortium:release-5.4 Jun 20, 2024
13 checks passed
@hjmjohnson hjmjohnson deleted the release-5.4-CI-update branch January 26, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants