Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Remove prompt and spaces in Markdown documentation bash blocks #4353

Merged
merged 1 commit into from
Dec 1, 2023
Merged

STYLE: Remove prompt and spaces in Markdown documentation bash blocks #4353

merged 1 commit into from
Dec 1, 2023

Conversation

jhlegarreta
Copy link
Member

Remove prompt symbol and spaces in Markdown documentation bash blocks: allows to copy and paste the commands directly.

PR Checklist

@jhlegarreta
Copy link
Member Author

Following #4320 (comment)

@github-actions github-actions bot added area:Python wrapping Python bindings for a class type:Style Style changes: no logic impact (indentation, comments, naming) area:Documentation Issues affecting the Documentation module labels Dec 1, 2023
@jhlegarreta jhlegarreta force-pushed the RemovePromptSignAndSpacesInMarkdownBashBlocks branch 2 times, most recently from 4596312 to 51f5a3e Compare December 1, 2023 03:59
@hjmjohnson
Copy link
Member

@jhlegarreta This is a good change, but it is conflicting with other changes recently committed.

@jhlegarreta
STYLE: Remove prompt and spaces in Markdown documentation bash blocks
d1aafe4 
Remove prompt symbol and spaces in Markdown documentation bash blocks:
allows to copy and paste the commands directly.
@jhlegarreta jhlegarreta force-pushed the RemovePromptSignAndSpacesInMarkdownBashBlocks branch from 51f5a3e to d1aafe4 Compare December 1, 2023 17:14
@jhlegarreta
Copy link
Member Author

@jhlegarreta This is a good change, but it is conflicting with other changes recently committed.

Done.

@dzenanz dzenanz merged commit a6036a8 into InsightSoftwareConsortium:master Dec 1, 2023
6 checks passed
@jhlegarreta jhlegarreta deleted the RemovePromptSignAndSpacesInMarkdownBashBlocks branch December 1, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees
No one assigned
Labels
area:Documentation Issues affecting the Documentation module area:Python wrapping Python bindings for a class type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhlegarreta @hjmjohnson @dzenanz