MersenneTwisterGlobals replace std::recursive_mutex with std::mutex, rename data member from "Lock" to "Mutex"
#4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `std::recursive_mutex` with the more lightweight `std::mutex` as type of `MersenneTwisterGlobals::m_StaticInstanceLock`. This mutex is only used `MersenneTwisterRandomVariateGenerator::GetInstance()`. This member function does not call itself, so the mutex does not need to be "recursive".
Following pull request InsightSoftwareConsortium#4217 commit 0150e46 STYLE: Rename private and internal data members from "Lock" to "Mutex"
dzenanz
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
std::recursive_mutexwith the more lightweightstd::mutexas type ofMersenneTwisterGlobals::m_StaticInstanceLock. This mutex is only used byMersenneTwisterRandomVariateGenerator::GetInstance(). This member function does not call itself, so the mutex does not need to be "recursive".Renamed
MersenneTwisterGlobals::m_StaticInstanceLocktoMersenneTwisterGlobals::m_StaticInstanceLockstd::mutexfrom "Lock" to "Mutex" #4217 commit 0150e46 STYLE: Rename private and internal data members from "Lock" to "Mutex"