MRC file format bug and compatibility fixes. #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The computed values are unused and MRC extended headers are not fully supported.
github-actions
bot
added
type:Infrastructure
|
The MRC input image file didn't get magically converted to a hash file. It will need to be manually updated. |
dzenanz
approved these changes
Apr 19, 2023
N-Dekker
reviewed
Apr 19, 2023
N-Dekker
reviewed
Apr 19, 2023
|
I uploaded the test file here: https://data.kitware.com/#folder/64413821cffd1a074ef04595 Here is the hash file to be put into the repository: |
blowekamp
force-pushed
the
mrc_bug_fixes
branch
from
c1b3432 to
f611ccd
Compare
MRC image collected as a tilt series had spacing being computed a zero. This causes the image to be unreadable but ITK. Set the spacing to 1 in the case.
The MRC2014 specification updated/clarifed the spec that the first two bytes should contain the specified value to determine endian. This appears to be enforced with Python mrcfile. This patch enables compatibility.
blowekamp
force-pushed
the
mrc_bug_fixes
branch
from
f611ccd to
8ca5d1f
Compare
dzenanz
approved these changes
Apr 24, 2023
|
Sorry, I merged these via rebase (without a merge commit). I now realize that will prevent same hashes from being used in release branch (#4023). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues with the system stamp, 0 -spacing, and remove dead code creating warnings.
This PR is also based on the release branch so that it can also be back patched.