COMP: Add test to ensure correct command line length.

Prefer to test input values are correct rather than ignore the unused variable.
InsightSoftwareConsortium · Apr 13, 2024 · 1938221 · 1938221
1 parent d6c6382
commit 1938221
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 5 deletions.
diff --git a/Modules/IO/ImageBase/test/itkImageFileReaderTest1.cxx b/Modules/IO/ImageBase/test/itkImageFileReaderTest1.cxx
@@ -23,7 +23,7 @@
 int
 itkImageFileReaderTest1(int argc, char * argv[])
 {
-
+  ITK_TEST_EXPECT_TRUE(argc == 1);
   using ImageNDType = itk::Image<short, 2>;
   using ReaderType = itk::ImageFileReader<ImageNDType>;
 

diff --git a/Modules/Registration/RegistrationMethodsv4/test/itkBSplineSyNImageRegistrationTest.cxx b/Modules/Registration/RegistrationMethodsv4/test/itkBSplineSyNImageRegistrationTest.cxx
@@ -75,8 +75,9 @@ class CommandIterationUpdate : public itk::Command
 
 template <unsigned int TDimension>
 int
-PerformBSplineSyNImageRegistration(int itkNotUsed(argc), char * argv[])
+PerformBSplineSyNImageRegistration(int argc, char * argv[])
 {
+  ITK_TEST_EXPECT_TRUE(argc == 4);
   const unsigned int ImageDimension = TDimension;
 
   using PixelType = double;

diff --git a/Modules/Registration/RegistrationMethodsv4/test/itkSimpleImageRegistrationTest3.cxx b/Modules/Registration/RegistrationMethodsv4/test/itkSimpleImageRegistrationTest3.cxx
@@ -120,7 +120,7 @@ template <unsigned int TDimension>
 int
 PerformCompositeImageRegistration(int argc, char * argv[])
 {
-  if (argc != 4)
+  if (argc != 5)
   {
     std::cout << "ERROR: incorrect number of arguments" << std::endl;
     return EXIT_FAILURE;

diff --git a/Modules/Registration/RegistrationMethodsv4/test/itkSimpleImageRegistrationTest4.cxx b/Modules/Registration/RegistrationMethodsv4/test/itkSimpleImageRegistrationTest4.cxx
@@ -77,8 +77,9 @@ class CommandIterationUpdate : public itk::Command
 
 template <unsigned int TDimension>
 int
-ImageRegistration(int itkNotUsed(argc), char * argv[])
+ImageRegistration(int argc, char * argv[])
 {
+  ITK_TEST_EXPECT_TRUE(argc == 4);
   const unsigned int ImageDimension = TDimension;
 
 

diff --git a/Modules/Registration/RegistrationMethodsv4/test/itkSyNImageRegistrationTest.cxx b/Modules/Registration/RegistrationMethodsv4/test/itkSyNImageRegistrationTest.cxx
@@ -111,7 +111,7 @@ template <unsigned int TDimension>
 int
 PerformDisplacementFieldImageRegistration(int argc, char * argv[])
 {
-  if (argc != 4)
+  if (argc != 5)
   {
     std::cout << "ERROR: incorrect number of arguments" << std::endl;
     return EXIT_FAILURE;