Skip to content

Commit

Permalink
ENH: Remove unconditionally true statement
Browse files Browse the repository at this point in the history
[CTest: warning matched] /Users/builder/externalModules/Filtering/ImageCompare/test/itkSimilarityIndexImageFilterTest.cxx:63:18:
warning: result of comparison of 0 <= unsigned expression is always true [-Wtautological-unsigned-zero-compare]
   63 |       if (lower1 <= count && count <= upper1)
      |           ~~~~~~ ^  ~~~~~
[CTest: warning suppressed] 1 warning generated.
  • Loading branch information
hjmjohnson committed Dec 18, 2024
1 parent 51a098f commit 144d19d
Showing 1 changed file with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,10 @@ itkSimilarityIndexImageFilterTest(int, char *[])
image1->Allocate();
image2->Allocate();

const unsigned long numOfPixels = image1->GetBufferedRegion().GetNumberOfPixels();
constexpr unsigned long lower1 = 0;
const unsigned long upper1 = static_cast<unsigned long>(static_cast<double>(numOfPixels) * 0.75) - 1;
const auto lower2 = static_cast<unsigned long>(static_cast<double>(numOfPixels) * 0.25);
const unsigned long upper2 = numOfPixels - 1;
const unsigned long numOfPixels = image1->GetBufferedRegion().GetNumberOfPixels();
const unsigned long upper1 = static_cast<unsigned long>(static_cast<double>(numOfPixels) * 0.75) - 1;
const auto lower2 = static_cast<unsigned long>(static_cast<double>(numOfPixels) * 0.25);
const unsigned long upper2 = numOfPixels - 1;

itk::ImageRegionIterator<Image1Type> it1(image1, image1->GetBufferedRegion());
itk::ImageRegionIterator<Image2Type> it2(image2, image2->GetBufferedRegion());
Expand All @@ -60,7 +59,7 @@ itkSimilarityIndexImageFilterTest(int, char *[])

if (!it1.IsAtEnd())
{
if (lower1 <= count && count <= upper1)
if (count <= upper1)
{
it1.Set(5);
}
Expand Down

0 comments on commit 144d19d

Please sign in to comment.