Client crash 3 #478
Open
Client crash 3 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementKunz
reviewed
Jan 21, 2025
src/gui/parametersdialog.cpp
Outdated
Comment on lines
1155
to
1158
| if (!errorTabWidget) { | ||
| qCDebug(lcParametersDialog()) << "Error widget not found for driveDbId=" << driveDbId; | ||
| return; | ||
| } |
There was a problem hiding this comment.
So this should never happen? Should we fix the problem at its source?
Also, what are the consequences of simply ignore this error here? (I am guessing that the error list will not be cleaned, is it ok?)
There was a problem hiding this comment.
I suspect this happens after a sync has been deleted, so clearing its errors widget is not a problem anymore.
There was a problem hiding this comment.
Fixed the source of the problem (I hope).
ddaed3e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.