Add some sentry to better understand message display improvements that still leave some overscroll #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
added
bug
FabianDevel
requested changes
Oct 29, 2024
app/src/main/java/com/infomaniak/mail/ui/main/thread/MessageWebViewClient.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/MessageWebViewClient.kt
Show resolved
Hide resolved
|
FabianDevel
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resizing the mail with js, after zooming, it can still scroll. Sometimes, the issue is caused because the target width in which we want to the fit all of the html is 0. In this case, no amount of processing will ever let us fit the content in a width of 0 obviously.
This PR adds a new clarifying sentry captureMessage to try and understand how we could possibly end up with a target width of 0 in the first place. This PR also adds a tag to the already existing captureMessage to understand in what proportion the issue is caused by zero-width webviews