fix: Remove quickActionBar blink when opening a Thread

Infomaniak · Jan 30, 2025 · e4a8ae7 · e4a8ae7
1 parent 7be6e08
commit e4a8ae7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/...rc/main/java/com/infomaniak/mail/ui/bottomSheetDialogs/UpgradeProductBottomSheetDialog.kt b/...rc/main/java/com/infomaniak/mail/ui/bottomSheetDialogs/UpgradeProductBottomSheetDialog.kt
@@ -28,7 +28,7 @@ class UpgradeProductBottomSheetDialog : InformationBottomSheetDialog() {
         super.onViewCreated(view, savedInstanceState)
 
         title.setText(R.string.disabledFeatureFlagTitle)
-        description.text = getString(R.string.disabledFeatureFlagDescription)
+        description.setText(R.string.disabledFeatureFlagDescription)
         infoIllustration.setBackgroundResource(R.drawable.ic_update_logo)
 
         actionButton.apply {

diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt b/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt
@@ -481,7 +481,7 @@ class ThreadFragment : Fragment() {
                 iconTint = ColorStateList.valueOf(color)
             }
 
-            binding.quickActionBar.isGone = thread.numberOfScheduledDrafts == thread.messages.size
+            binding.quickActionBar.isVisible = thread.numberOfScheduledDrafts != thread.messages.size
         }
     }
 

diff --git a/app/src/main/res/layout/fragment_thread.xml b/app/src/main/res/layout/fragment_thread.xml
@@ -121,11 +121,13 @@
             android:id="@+id/quickActionBar"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
+            android:visibility="gone"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toBottomOf="@id/threadCoordinatorLayout"
-            app:menu="@menu/message_menu" />
+            app:menu="@menu/message_menu"
+            tools:visibility="visible" />
     </androidx.constraintlayout.widget.ConstraintLayout>
 
     <com.infomaniak.mail.ui.main.EmptyStateView
-Original file line number
+Diff line change
@@ Expand Up / @@ -481,7 +481,7 @@ class ThreadFragment : Fragment() { @@
                     iconTint = ColorStateList.valueOf(color)
                 }
-                binding.quickActionBar.isGone = thread.numberOfScheduledDrafts == thread.messages.size
+                binding.quickActionBar.isVisible = thread.numberOfScheduledDrafts != thread.messages.size
             }
         }
@@ Expand Down @@