-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreign policy signaling #359
Open
Danarca
wants to merge
14
commits into
Imperia-Core
Choose a base branch
from
Imperia-foreign-policy-signalling
base: Imperia-Core
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI can now change policy through an on_monthly. Their current diplomatic agenda/strategy is usually the deciding factor, with the exception of true neutrality (requires the modifier/status) and isolationism (which requires the trade law of the same name). Also re-configured the GLOBAL so it only goes through each country once. Small performance gain on starting the game, I assume :s Since this GLOBAL is fired immediately before the player takes control, even player countries get a relatively correct law! Just in case, the restricting variable is removed after firing in the GLOBAL, so players can select their own.
…m/Imperia-Development-Victoria-3/Victoria-3-Dev into Imperia-foreign-policy-signalling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-added the foreign policy law set, purely cosmetic this time around.
Re-added the executive policy panel, seems to work fine, but we'll see what the Tiger says...
Added multiple new cosmetic laws to the group, such as Splendid Isolationism, Manifest Destiny, and more.
True Neutrals (Such as the Swiss) are locked to the True Neutral law, and..
... I need to add the ability for players to get the law, if it doesnt work out of the box, actually.Fixed.Anyways, subjects have 3 subject-specific laws, but still has access to the others.
AI bases their foreign policy law on their diplomatic agenda/strategy.
Players get the same call in the GLOBAL, which works since players havent taken control technically when it fires. Armed Neutrality is in the imperia political setup effect as a fallback.
Players can change their foreign policy from the start, but for both players and AI theres a 6-month cooldown.
Reconfigured the GLOBAL, since we called
every_country
like 4 times.COPILOT SAYS:
This pull request introduces several changes to the foreign policy system in the game. The most significant updates include the addition of new laws related to diplomatic stances, updates to the global settings, and modifications to the user interface to accommodate these changes.
Foreign Policy System Enhancements:
common/laws/imperia_diplomatic_stance.txt
: Added new laws for various diplomatic stances, such as expansionism, imperialism, armed neutrality, and more. These laws define how countries interact with the world and include specific conditions for enactment and visibility.Global Settings Updates:
common/history/global/imperia_global.txt
: Reorganized and added new initial setup configurations, including a bureaucracy bonus, money transfer setup, and starting foreign policy settings. Removed outdated configurations related to strategic regions and bureaucracy bonuses. [1] [2]AI and Scripted Effects:
common/scripted_effects/imperia_foreign_policy_effects.txt
: Introduced scripted effects to update AI foreign policy based on specific strategies and conditions, ensuring AI countries adapt their foreign policies dynamically.common/on_actions/imperia_on_monthtly_pulse.txt
: Added a new action to change AI foreign policy during the monthly pulse if applicable.User Interface Modifications:
gui/imperia_politics_panel_types.gui
: Updated the GUI to include new panels and controls for enacting foreign policy laws, allowing players to quickly enact or cancel laws with appropriate tooltips and progress indicators.Localization:
localization/english/imperia_law_l_english.yml
: Added localization entries for the new foreign policy laws and related GUI elements to ensure proper display of names and descriptions in the game.