Disallow measurement report with no measurement groups #325
+145
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #324 (@nicolay-r)
Explicitly disallow passing None for the
imaging_measurementsparameter of theMeasurementReportclass. Previously this failed with a bug relating to an unbound variable.Note that I have still kept the
imaging_measurementsas an "optional" parameter in terms of the function signature in order to allow expansion in the future to add support for qualitative evaluations or image derived measurements (rows 10 and 12 of the TID1500 table).I further looked through static analysis results on this file in case there were other cases with similar "indentation problems" leading to potentially unbound locals. I found one in the
ImageLibraryclass that would prevent multiple image library groups being added to the library. This is fixed also