Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(chip): remove duplicated dragging section #5999

Open
wants to merge 10 commits into
base: vnext
Choose a base branch
from

Conversation

teodosiah
Copy link
Contributor

Closes #5998

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in topic content has a valuable update, it's new or considered as preview\ beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@@ -121,21 +121,6 @@ public chipRemoved(event: IBaseChipEventArgs) {
this.changeDetectionRef.detectChanges();
}
```

### Dragging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see duplicate section of this one. We'll lose this content if removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chip draggable property is also mentioned in the Reorder Chips section

Copy link
Contributor

@dkamburov dkamburov Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added @skrustev for a review, he can tell if this section was added for a reason

Copy link
Member

@skrustev skrustev Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine for the section to be left as is. It is mentioned with the Chip Area, but it is a standalone thing to the chip itself. The part describing the demo though should definitely be somewhere else imo. I think moving it to a separate section after the Chip Templates section should suffice.

I noticed though the draggable link points to the removable property.
Also I think having a link to the Chip Area Reorder Chips section here would also be nice. The IgxChipsAreaComponent note says it is needed, but that is not required. The user could implement its own thing even without the Chip Area. So I think mentioning it as an option with the link to the Reorder Chips would be much better replacement for the note.

@dkamburov dkamburov requested a review from skrustev November 25, 2024 14:06
skrustev
skrustev previously approved these changes Jan 9, 2025
@gedinakova gedinakova self-assigned this Jan 10, 2025
@gedinakova
Copy link
Contributor

@teodosiah @skrustev Looking into the new structure, isn't it better if we also add a section for this demo, similar to what we have in Chip Area and Styling sections:
image

So I suggest, adding a demo section at the bottom of Using the Angular Chip Component that starts with (but making it normal, not bold):
image

Copy link
Contributor

@gedinakova gedinakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have an aditional Demo section under Using the Angular Chip Component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants