-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(chip): remove duplicated dragging section #5999
base: vnext
Are you sure you want to change the base?
Conversation
@@ -121,21 +121,6 @@ public chipRemoved(event: IBaseChipEventArgs) { | |||
this.changeDetectionRef.detectChanges(); | |||
} | |||
``` | |||
|
|||
### Dragging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see duplicate section of this one. We'll lose this content if removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chip draggable property is also mentioned in the Reorder Chips section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added @skrustev for a review, he can tell if this section was added for a reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine for the section to be left as is. It is mentioned with the Chip Area, but it is a standalone thing to the chip itself. The part describing the demo though should definitely be somewhere else imo. I think moving it to a separate section after the Chip Templates
section should suffice.
I noticed though the draggable
link points to the removable
property.
Also I think having a link to the Chip Area Reorder Chips
section here would also be nice. The IgxChipsAreaComponent
note says it is needed, but that is not required. The user could implement its own thing even without the Chip Area. So I think mentioning it as an option with the link to the Reorder Chips
would be much better replacement for the note.
@teodosiah @skrustev Looking into the new structure, isn't it better if we also add a section for this demo, similar to what we have in So I suggest, adding a demo section at the bottom of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have an aditional Demo
section under Using the Angular Chip Component
.
Closes #5998
Checklist:
preview
\beta
../relative/path.md
IgxSelectComponent
,<igx-combo>
code blocks
for the names of classes / tags / propertiescode blocks
pending-localization
label when the review of the PR is done