Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(icon-button): create article #4016

Merged
merged 4 commits into from
Nov 30, 2023
Merged

docs(icon-button): create article #4016

merged 4 commits into from
Nov 30, 2023

Conversation

SisIvanova
Copy link
Contributor

Related to IgniteUI/igniteui-angular/issues/13590

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in topic content has a valuable update, it's new or considered as preview\ beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@SisIvanova SisIvanova requested a review from simeonoff November 23, 2023 13:55
@SisIvanova SisIvanova marked this pull request as ready for review November 29, 2023 13:32
Comment on lines 154 to 156
```scss
@use "igniteui-angular/theming" as *;
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a necessary step when using CSS vars.

Comment on lines 162 to 170
--background: #011627;
--foreground: #FEFEFE;
--hover-foreground: #011627dc;
--hover-background: #ECAA53;
--focus-foreground: #011627dc;
--focus-background: #ECAA53;
--focus-border-color: #0116276c;
--active-foreground: #011627dc;
--active-background: #ECAA53;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, normalize the HEX values to be lower case only.

@simeonoff simeonoff merged commit fb407d5 into vnext Nov 30, 2023
4 checks passed
@simeonoff simeonoff deleted the sivanova/icon-button branch November 30, 2023 08:26
randriova added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants