Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update guide additional steps for 16.1.x to 17.0.x #3973

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

wnvko
Copy link
Contributor

@wnvko wnvko commented Nov 3, 2023

Add notes in update guide about breaking changes in combo and simple combo.

Closes #3972

Checklist:

  • check topic's TOC/menu and paragraph headings
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@wnvko wnvko changed the base branch from master to vnext November 3, 2023 15:37
@wnvko wnvko requested a review from randriova November 3, 2023 15:38
@wnvko wnvko added combo simple combo IgxSimpleCombo component labels Nov 3, 2023
@wnvko wnvko requested a review from Lipata November 3, 2023 16:41
en/components/general/update-guide.md Outdated Show resolved Hide resolved
en/components/general/update-guide.md Outdated Show resolved Hide resolved
en/components/general/update-guide.md Show resolved Hide resolved
@wnvko wnvko requested a review from Lipata November 7, 2023 14:25
@hanastasov
Copy link
Contributor

Closing in favour of #3980

@damyanpetev damyanpetev changed the title Update guide for combo docs: Update guide additional steps for 16.1.x to 17.0.x Nov 9, 2023
Lipata
Lipata previously approved these changes Nov 9, 2023
@damyanpetev damyanpetev merged commit 4fe73c5 into vnext Nov 9, 2023
4 checks passed
@damyanpetev damyanpetev deleted the mvenkov/update-guide-for-combo branch November 9, 2023 17:37
randriova added a commit that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add migration guide for breaking change in 17.0
6 participants