Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ttonev/hr portal sample #3571

Closed
wants to merge 8 commits into from
Closed

Ttonev/hr portal sample #3571

wants to merge 8 commits into from

Conversation

tishko0
Copy link
Contributor

@tishko0 tishko0 commented Nov 26, 2024

No description provided.

@tishko0 tishko0 changed the base branch from master to vnext November 26, 2024 08:58
@yradoeva
Copy link

Here are the things I noticed, related to the design:

  1. Can we make the so-called “zebra” styling of the rows by making the row-even-background color surface light (ig-surface-500)?
Executive
  1. The gap between flags and countries/cities and between the buttons in Contacts column should be 8px (not 10px)
tria
  1. There should be a gap of 8px also between the Avatar and the names in the Name column
    John Smith

  2. “Job Title” and “Gross Salary” should have an interval

  3. The flags should be smaller - 18x14px (not 24x18px)

  4. The flags should have rounded corners with border-radius of 1px and a shadow - Elevations/Shadow.01

Pasted Graphic 9
  1. Hire Date - for some reason all months appear as “00”, but they shouldn’t
    Hire Date

  2. The Quick Filter is missing:

Pasted Graphic 5
  1. Gross Salary header cell should be right-aligned
Gross Salary

Theming Related:

  1. Font should be Open Sans for Fluent theme
  2. All Buttons are with All Caps, but they shouldn’t. That applies to the buttons in the Toolbar, in Excel Style filtering and in Advanced filtering dialogs
    By design:
image

@dkamburov dkamburov closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants