Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(angular material): components and styling #3418

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

SisIvanova
Copy link
Contributor

Closes #3417

@SisIvanova SisIvanova added the refactoring Use it to mark that the changes made are refactoring. label Dec 1, 2023
@simeonoff simeonoff self-requested a review December 5, 2023 08:49
simeonoff
simeonoff previously approved these changes Dec 5, 2023
private _dialogOverlaySettings2;

constructor(private _formBuilder: FormBuilder) {}
constructor(private _formBuilder: FormBuilder, private overlayContainer: OverlayContainer) {
overlayContainer.getContainerElement().classList.add('light-menu-theme');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
overlayContainer.getContainerElement().classList.add('light-menu-theme');
this.toggleOverlayClasses(this.themeClass);

Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call toggleOverlayClasses in the constructor.

@simeonoff simeonoff self-requested a review December 5, 2023 08:52
@simeonoff simeonoff merged commit bd73c24 into master Dec 5, 2023
3 checks passed
@simeonoff simeonoff deleted the sivanova/angular-sample branch December 5, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Use it to mark that the changes made are refactoring. status: awaiting-test version: 17.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular Material: Update sample to match theme
2 participants