Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): update 17 #3402

Merged
merged 29 commits into from
Nov 10, 2023
Merged

chore(*): update 17 #3402

merged 29 commits into from
Nov 10, 2023

Conversation

Lipata
Copy link
Member

@Lipata Lipata commented Nov 8, 2023

No description provided.

@Lipata Lipata requested a review from ChronosSF November 8, 2023 13:05
@zdrawku
Copy link
Contributor

zdrawku commented Nov 9, 2023

@Lipata, @dobromirts is aware of the problem with the live-editing build, he will submit a fix shortly and re-test

@zdrawku
Copy link
Contributor

zdrawku commented Nov 9, 2023

Actually, the problem comes from the library itself, as @ChronosSF pointed out "We should either add a migration for this, add it in the migration guide or make the parameter optional, if possible"

IgniteUI/igniteui-angular#13656

@kdinev
Copy link
Member

kdinev commented Nov 9, 2023

@zdrawku I will update the live-editing.

@zdrawku
Copy link
Contributor

zdrawku commented Nov 9, 2023

We can start testing on staging once the PR is merged

@ChronosSF ChronosSF merged commit fc42fb5 into vnext Nov 10, 2023
@ChronosSF ChronosSF deleted the nalipiev/update-17 branch November 10, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants