-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GHA dependencies via dependabot #813
Conversation
.github/dependabot.yml
Outdated
directory: / | ||
schedule: | ||
interval: daily | ||
open-pull-requests-limit: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the PR limit? (I know it was already there still I'm wondering why it's necessary).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess to limit the PRs it can create at a time, but I can also remove it, I just wanted it to be identical to the other config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, Dependabot opens a maximum of five pull requests for version updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then 5 PRs a day is more than enough for the GitHub Actions, I would say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 PRs a day
This is not a rate limit:
Once there are five open pull requests from Dependabot, Dependabot will not open any new requests until some of those open requests are merged or closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevertheless, the default limit is more than enough for the GA.
You have to force merge this PR though, so that it can start upgrading the dependencies from within the main branch. |
24945d2
to
793db3d
Compare
Dependabot supports to automatically refresh GitHub actions as well, so we should use it to avoid such errors:
https://github.com/Icinga/icingadb/actions/runs/10903916830/job/30259089610