Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQSS/9247 Curation Status Updates #11268

Open
wants to merge 54 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Feb 15, 2025

What this PR does / why we need it: This PR extends the External/Curation Status Label mechanism:

  • adding tracking of who creates the status label and when,
  • keeping a history of past statuses
  • updating the CSV report to include the creation time and assigner of a status
  • updating the getCurationStatus api call to return a JSON object for the status with label, assigner, and create time
  • adding an includeHistory query param for these API calls to allow seeing prior statuses
  • adding a facet to allow filtering by curation status (for users able to set them)
  • adding the creation time to solr as a pdate to support search by time period, e.g. current status set prior to a give date
  • standardizing the language around 'curation status' vs 'external status'
  • adding a 'curation-status' class to displayed labels to allow styling
  • fixing a bug in the notification display that would show the current status rather than the status as of the notification time
  • improving the email message to include a link to the dataset and the name of/link to the collection its in.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Verify that curation statuses can be set/removed when the overall curation status mechanism is enabled. Verify that the status can be removed. Verify that status is removed at publication. Verify that the /api/datasets/{id}//curationStatus and /api/datasets/{id}/listCurationStates api calls return correct results, with and without the ?includeHistory=true flag. (Most of this is tested in IT tests as well.)

Does this PR introduce a user interface change? If mockups are available, please link/include them here: New facet:
image

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Feb 15, 2025

Coverage Status

coverage: 22.711% (-0.03%) from 22.741%
when pulling d2c79a8 on QualitativeDataRepository:IQSS/9247-CurationStatus_updates
into 4b3afe3 on IQSS:develop.

@qqmyers qqmyers added Size: 10 A percentage of a sprint. 7 hours. GDCC: QDR of interest to QDR labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GDCC: QDR of interest to QDR Size: 10 A percentage of a sprint. 7 hours.
Projects
Status: No status
2 participants