Skip to content

Commit

Permalink
Remove obsolete comment about get()/remove() concurrency.
Browse files Browse the repository at this point in the history
This paragraph has most likely become obsolete with commit d8c3fff00b93.
At the moment, the interaction of get() and remove() is exactly as one
would expect: if get() gets the lock before remove(), the block is
removed - otherwise it remains. The comment muddles the water more
than clarifying the behavior.
  • Loading branch information
Nikratio committed Sep 23, 2018
1 parent 7373c90 commit 3fd3070
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/s3ql/block_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,6 @@ def get(self, inode, blockno):
"""Get file handle for block `blockno` of `inode`
This method releases the global lock.
Note: if `get` and `remove` are called concurrently, then it is
possible that a block that has been requested with `get` and
passed to `remove` for deletion will not be deleted.
"""

#log.debug('started with %d, %d', inode, blockno)
Expand Down

0 comments on commit 3fd3070

Please sign in to comment.