Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to Kubernetes as part of pipeline #9850

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

wkoot
Copy link
Contributor

@wkoot wkoot commented Sep 24, 2024

Closes #8204

@wkoot wkoot linked an issue Sep 24, 2024 that may be closed by this pull request
@wkoot wkoot force-pushed the 8204-deploy-to-kubernetes-as-part-of-pipeline branch 29 times, most recently from 9bad6a9 to 5db4462 Compare September 26, 2024 10:28
@wkoot wkoot force-pushed the 8204-deploy-to-kubernetes-as-part-of-pipeline branch 11 times, most recently from 6a1fb9a to f56ac2f Compare September 26, 2024 11:51
wkoot added a commit that referenced this pull request Sep 26, 2024
@wkoot wkoot force-pushed the 8204-deploy-to-kubernetes-as-part-of-pipeline branch from f56ac2f to ac54a8c Compare September 26, 2024 11:55
@wkoot wkoot marked this pull request as ready for review September 26, 2024 11:55
@wkoot wkoot force-pushed the 8204-deploy-to-kubernetes-as-part-of-pipeline branch from ac54a8c to ce8ef20 Compare September 26, 2024 11:55
wkoot added a commit that referenced this pull request Sep 26, 2024
@wkoot wkoot requested a review from fniessink September 26, 2024 12:00
wkoot added a commit that referenced this pull request Sep 26, 2024
@wkoot wkoot force-pushed the 8204-deploy-to-kubernetes-as-part-of-pipeline branch from ce8ef20 to e8b87b5 Compare September 26, 2024 18:01
Copy link
Member

@fniessink fniessink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where/how SonarQube is deployed? We're generating passwords for SonarQube and Progress, but why if they are not used?

@wkoot
Copy link
Contributor Author

wkoot commented Sep 27, 2024

I don't understand where/how SonarQube is deployed?

The final step Build and run chart deploys to a local kubernetes instance which is ran on minikube.
See also the corresponding github action: https://github.com/marketplace/actions/setup-minikube :-)
After installing the helm chart, the test waits for ready checks and all deployments being marked as available.

wkoot added a commit that referenced this pull request Oct 1, 2024
@wkoot wkoot force-pushed the 8204-deploy-to-kubernetes-as-part-of-pipeline branch from e8b87b5 to 20fc867 Compare October 1, 2024 08:20
@ICTU ICTU deleted a comment from gitguardian bot Oct 1, 2024
@wkoot wkoot force-pushed the 8204-deploy-to-kubernetes-as-part-of-pipeline branch from 20fc867 to d04a0b4 Compare October 1, 2024 09:35
Copy link

gitguardian bot commented Oct 1, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@wkoot wkoot merged commit b7a3d6f into master Oct 1, 2024
29 of 33 checks passed
@wkoot wkoot deleted the 8204-deploy-to-kubernetes-as-part-of-pipeline branch October 1, 2024 09:38
Copy link

sonarqubecloud bot commented Oct 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy to Kubernetes as part of pipeline
2 participants