Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multi-stage build for frontend container #10239

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Use multi-stage build for frontend container #10239

merged 1 commit into from
Nov 13, 2024

Conversation

fniessink
Copy link
Member

@fniessink fniessink commented Nov 5, 2024 •
edited
Loading 

REPOSITORY                  TAG      IMAGE ID       CREATED          SIZE
ictu/quality-time_frontend  v5.18.0  77aed96f843b   10 minutes ago   186MB
...
ictu/quality-time_frontend  v5.17.1  b136d1ea1ceb   8 days ago       803MB

@fniessink fniessink force-pushed the dont-npm-install-dev-deps-in-container branch 3 times, most recently from 0bf3065 to 8cc20f9 Compare November 5, 2024 18:58
@fniessink fniessink marked this pull request as draft November 5, 2024 19:29
@fniessink fniessink requested a review from wkoot November 5, 2024 19:29
@fniessink fniessink force-pushed the dont-npm-install-dev-deps-in-container branch from 8cc20f9 to 1399612 Compare November 13, 2024 19:03
@fniessink fniessink marked this pull request as ready for review November 13, 2024 19:04
@fniessink fniessink force-pushed the dont-npm-install-dev-deps-in-container branch from 1399612 to ce0292b Compare November 13, 2024 19:05
@fniessink fniessink changed the title Don't npm install dev dependencies in frontend container. Use multi-stage build for frontend container Nov 13, 2024
@fniessink fniessink force-pushed the dont-npm-install-dev-deps-in-container branch from ce0292b to 38501f4 Compare November 13, 2024 19:23
@fniessink fniessink force-pushed the dont-npm-install-dev-deps-in-container branch from 38501f4 to 0081ac2 Compare November 13, 2024 19:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fniessink fniessink merged commit dc7335c into master Nov 13, 2024
34 checks passed
@fniessink fniessink deleted the dont-npm-install-dev-deps-in-container branch November 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkoot wkoot wkoot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fniessink @wkoot