After clicking "Add metric", give focus to the filter field automatic…

…ally. Closes #10743.
ICTU · Feb 6, 2025 · 0be7f8e · 0be7f8e
1 parent 5376a39
commit 0be7f8e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/components/frontend/src/widgets/buttons/AddDropdownButton.jsx b/components/frontend/src/widgets/buttons/AddDropdownButton.jsx
@@ -105,6 +105,7 @@ export function AddDropdownButton({ itemSubtypes, itemType, onClick, allItemSubt
             </Tooltip>
             <Popover id="dropdown-menu" anchorEl={anchorEl} onClose={() => setAnchorEl(null)} open={Boolean(anchorEl)}>
                 <TextField
+                    autoFocus
                     fullWidth
                     label={`Filter ${itemType} types`}
                     onChange={(event) => setQuery(event.target.value)}

diff --git a/components/frontend/src/widgets/buttons/AddDropdownButton.test.jsx b/components/frontend/src/widgets/buttons/AddDropdownButton.test.jsx
@@ -38,6 +38,7 @@ test("AddDropdownButton mouse navigation", async () => {
     await act(async () => {
         fireEvent.click(screen.getByText(/Add foo/))
     })
+    expect(screen.getByLabelText(/Filter/)).toHaveFocus()
     await act(async () => {
         fireEvent.click(screen.getByText(/Sub 2/))
     })
@@ -49,6 +50,7 @@ test("AddDropdownButton keyboard navigation", async () => {
     await act(async () => {
         fireEvent.click(screen.getByText(/Add foo/))
     })
+    expect(screen.getByLabelText(/Filter/)).toHaveFocus()
     await act(async () => {
         fireEvent.keyDown(screen.getByText(/Available/), { key: "ArrowDown" })
     })

diff --git a/docs/src/changelog.md b/docs/src/changelog.md
@@ -17,6 +17,7 @@ If your currently installed *Quality-time* version is not the latest version, pl
 ### Added
 
 - Support the new SonarQube impact severity levels "blocker" and "info", introduced in SonarQube v10.8. Closes [#10708](https://github.com/ICTU/quality-time/issues/10708).
+- After clicking "Add metric", give focus to the filter field automatically. Closes [#10743](https://github.com/ICTU/quality-time/issues/10743).
 
 ### Fixed