feat(PDNS): update custom resolver profile and views. #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunchauhanibm
changed the title
|
Signing off the Terraform support for provider |
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Show resolved
Hide resolved
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Outdated
Show resolved
Hide resolved
arjunchauhanibm
force-pushed
the
add_views
branch
from
5c37702 to
5f31a2b
Compare
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_forwarding_rule.go
Outdated
Show resolved
Hide resolved
|
Testing Doc: https://ibm.ent.box.com/notes/1654095457908 |
hkantare
reviewed
Nov 12, 2024
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Outdated
Show resolved
Hide resolved
|
Approved PR |
There was a problem hiding this comment.
Hi @arjunchauhanibm, I added my suggested edits in the comments. It's ready for you to review again, thanks!
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_forwarding_rule.go
Outdated
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_forwarding_rule.go
Show resolved
Hide resolved
ibm/service/dnsservices/data_source_ibm_private_dns_custom_resolver_forwarding_rules.go
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_forwarding_rule.go
Show resolved
Hide resolved
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_forwarding_rule.go
Show resolved
Hide resolved
arjunchauhanibm
changed the title
hkantare
reviewed
Jan 17, 2025
| @@ -1,8 +1,8 @@ | |||
| module github.com/IBM-Cloud/terraform-provider-ibm | |||
|
|
|||
| go 1.22.5 | |||
| go 1.23.3 | |||
There was a problem hiding this comment.
we need to check if all go sdk are compatible or n't
can we roll back to 1.22
| @@ -165,6 +181,36 @@ func ResourceIBMPrivateDNSCustomResolver() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| }, | |||
| }, | |||
| pdnsCRFRViews: { | |||
| Type: schema.TypeList, | |||
There was a problem hiding this comment.
Can we have Type as TypeSet when u add multiple items when we run plan may be it will show diff since list is unordered list
There was a problem hiding this comment.
Same comment holds for all list types
hkantare
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: