fix(auth): Updated vpc service version #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveclay
reviewed
Jun 30, 2022
bluemix/authentication/vpc/vpc.go
Outdated
| @@ -9,7 +9,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| DefaultMetadataServiceVersion = "2021-09-30" | |||
| DefaultMetadataServiceVersion = "2022-06-30" | |||
There was a problem hiding this comment.
Please see the recommended change here #327 (comment)
There was a problem hiding this comment.
Is there an advantage to using the current date over the date in the defect link?
steveclay
requested changes
Jun 30, 2022
steveclay
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR will update the VPC service version to allow VPC authentication
Steps to Test
go get github.com/IBM-Cloud/ibm-cloud-cli-sdk@d8a884dadc543de917266dc6b67a3f7608bf94e3ibmcloud config --trace trueibmcloud login --vpc-criinvalid_version_rangedoes not get returned